Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix daily challenge notification spam #29363

Merged
merged 5 commits into from
Aug 12, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clean up some naming weirdness
  • Loading branch information
bdach committed Aug 12, 2024
commit 54a1d791362c31da283ca3afd33a3841e440e92e
6 changes: 3 additions & 3 deletions osu.Game/Screens/Menu/DailyChallengeButton.cs
Original file line number Diff line number Diff line change
Expand Up @@ -132,21 +132,21 @@ protected override void Update()

private long? lastNotifiedDailyChallengeRoomId;

private void dailyChallengeChanged(ValueChangedEvent<DailyChallengeInfo?> info)
private void dailyChallengeChanged(ValueChangedEvent<DailyChallengeInfo?> _)
{
UpdateState();

scheduledCountdownUpdate?.Cancel();
scheduledCountdownUpdate = null;

if (this.info.Value == null)
if (info.Value == null)
{
Room = null;
cover.OnlineInfo = TooltipContent = null;
}
else
{
var roomRequest = new GetRoomRequest(this.info.Value.Value.RoomID);
var roomRequest = new GetRoomRequest(info.Value.Value.RoomID);

roomRequest.Success += room =>
{
Expand Down