Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show timing points in timeline when at the timing screen #29211

Merged
merged 2 commits into from
Jul 31, 2024

Always show timing points in timeline when at the timing screen

2d52bab
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Always show timing points in timeline when at the timing screen #29211

Always show timing points in timeline when at the timing screen
2d52bab
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (Windows, MultiThreaded) failed Jul 31, 2024 in 0s

10281 passed, 1 failed and 74 skipped

Tests failed

❌ TestResults-Windows-MultiThreaded.trx

10356 tests were completed in 2782s with 10281 passed, 1 failed and 74 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Visual.Navigation.TestSceneScreenNavigation 89✅ 1❌ 126s

❌ osu.Game.Tests.Visual.Navigation.TestSceneScreenNavigation

❌ TestAttemptPlayBeatmapMissingFails
	System.IO.IOException : The process cannot access the file 'C:\Users\runneradmin\AppData\Local\Temp\of-test-headless\TestSceneScreenNavigation-33a0dcfa-5a91-4bde-b509-01d8439d56ad\files\9\91\910a9d9291549ab1a8562aa07e148f4b8bea9f0a873b8c149fcdfa73d9df799c' because it is being used by another process.
✅ TestAttemptPlayBeatmapMissingFails
✅ TestAttemptPlayBeatmapWrongHashFails
✅ TestAttemptPlayBeatmapWrongHashFails
✅ TestBeatmapListingLinkSearchOnInitialOpen
✅ TestBeatmapListingLinkSearchOnInitialOpen
✅ TestBeatmapOptionsInput
✅ TestBeatmapOptionsInput
✅ TestConfirmationRequiredToDiscardPlaylist(False)
✅ TestConfirmationRequiredToDiscardPlaylist(False)
✅ TestConfirmationRequiredToDiscardPlaylist(True)
✅ TestConfirmationRequiredToDiscardPlaylist(True)
✅ TestConstructor
✅ TestConstructor
✅ TestDeleteAllScoresAfterPlaying
✅ TestDeleteAllScoresAfterPlaying
✅ TestDeleteScoreAfterPlaying
✅ TestDeleteScoreAfterPlaying
✅ TestExitGameFromSongSelect
✅ TestExitGameFromSongSelect
✅ TestExitImmediatelyAfterCompletion
✅ TestExitImmediatelyAfterCompletion
✅ TestExitMultiWithBackButton
✅ TestExitMultiWithBackButton
✅ TestExitMultiWithEscape
✅ TestExitMultiWithEscape
✅ TestExitSongSelectAndImmediatelyClickLogo
✅ TestExitSongSelectAndImmediatelyClickLogo
✅ TestExitSongSelectWithClick
✅ TestExitSongSelectWithClick
✅ TestExitSongSelectWithEscape
✅ TestExitSongSelectWithEscape
✅ TestExitWithHoldDisabled
✅ TestExitWithHoldDisabled
✅ TestExitWithOperationInProgress
✅ TestExitWithOperationInProgress
✅ TestFeaturedArtistDisclaimerDialog
✅ TestFeaturedArtistDisclaimerDialog
✅ TestForceExitWithOperationInProgress
✅ TestForceExitWithOperationInProgress
✅ TestMainOverlaysClosesNotificationOverlay
✅ TestMainOverlaysClosesNotificationOverlay
✅ TestMainOverlaysClosesSettingsOverlay
✅ TestMainOverlaysClosesSettingsOverlay
✅ TestMenuMakesMusic
✅ TestMenuMakesMusic
✅ TestModSelectInput
✅ TestModSelectInput
✅ TestModsResetOnEnteringMultiplayer
✅ TestModsResetOnEnteringMultiplayer
✅ TestOpenModSelectOverlayUsingAction
✅ TestOpenModSelectOverlayUsingAction
✅ TestOpenOptionsAndExitWithEscape
✅ TestOpenOptionsAndExitWithEscape
✅ TestOverlayClosing
✅ TestOverlayClosing
✅ TestPresentBeatmapAfterDeletion
✅ TestPresentBeatmapAfterDeletion
✅ TestPushMatchSubScreenAndPressBackButtonImmediately
✅ TestPushMatchSubScreenAndPressBackButtonImmediately
✅ TestPushSongSelectAndPressBackButtonImmediately
✅ TestPushSongSelectAndPressBackButtonImmediately
✅ TestQuickSkinEditorDoesntNukeSkin
✅ TestQuickSkinEditorDoesntNukeSkin
✅ TestRetryCountIncrements
✅ TestRetryCountIncrements
✅ TestRetryFromResults
✅ TestRetryFromResults
✅ TestRetryImmediatelyAfterCompletion
✅ TestRetryImmediatelyAfterCompletion
✅ TestSettingsViaHotkeyFromMainMenu
✅ TestSettingsViaHotkeyFromMainMenu
✅ TestShowMedalAtResults
✅ TestShowMedalAtResults
✅ TestSongContinuesAfterExitPlayer(False)
✅ TestSongContinuesAfterExitPlayer(False)
✅ TestSongContinuesAfterExitPlayer(True)
✅ TestSongContinuesAfterExitPlayer(True)
✅ TestSongSelectBackActionHandling
✅ TestSongSelectBackActionHandling
✅ TestSongSelectScrollHandling
✅ TestSongSelectScrollHandling
✅ TestToolbarHiddenByUser
✅ TestToolbarHiddenByUser
✅ TestTouchScreenDetectionAtSongSelect
✅ TestTouchScreenDetectionAtSongSelect
✅ TestTouchScreenDetectionInGame
✅ TestTouchScreenDetectionInGame
✅ TestWaitForNextTrackInMenu
✅ TestWaitForNextTrackInMenu

Annotations

Check failure on line 276 in osu.Game.Tests/Visual/Navigation/TestSceneScreenNavigation.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Tests.Visual.Navigation.TestSceneScreenNavigation ► TestAttemptPlayBeatmapMissingFails

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
  System.IO.IOException : The process cannot access the file 'C:\Users\runneradmin\AppData\Local\Temp\of-test-headless\TestSceneScreenNavigation-33a0dcfa-5a91-4bde-b509-01d8439d56ad\files\9\91\910a9d9291549ab1a8562aa07e148f4b8bea9f0a873b8c149fcdfa73d9df799c' because it is being used by another process.
Raw output
System.IO.IOException : The process cannot access the file 'C:\Users\runneradmin\AppData\Local\Temp\of-test-headless\TestSceneScreenNavigation-33a0dcfa-5a91-4bde-b509-01d8439d56ad\files\9\91\910a9d9291549ab1a8562aa07e148f4b8bea9f0a873b8c149fcdfa73d9df799c' because it is being used by another process.
   at System.IO.FileSystem.DeleteFile(String fullPath)
   at osu.Framework.Platform.NativeStorage.Delete(String path)
   at osu.Game.Tests.Visual.Navigation.TestSceneScreenNavigation.<>c__DisplayClass11_0.<TestAttemptPlayBeatmapMissingFails>b__4() in D:\a\osu\osu\osu.Game.Tests\Visual\Navigation\TestSceneScreenNavigation.cs:line 276
   at osu.Framework.Testing.Drawables.Steps.SingleStepButton.<.ctor>b__1_0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in D:\a\osu\osu\osu.Game\Tests\Visual\OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)