Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust chat sizing to better fit long usernames #29201

Merged
merged 8 commits into from
Jul 30, 2024

Conversation

peppy
Copy link
Member

@peppy peppy commented Jul 30, 2024

Arguably 12 point is too small, but we use it in so many other places. It's more likely that a lot of other text is just too large 🤷

  • Reduce clutter by only showing timestamps when more than a minute has passed
  • Reduce size of font and padding
  • Don't show seconds
Before After
osu! 2024-07-30 at 09 00 01 osu! 2024-07-30 at 08 59 32
osu! 2024-07-30 at 09 00 18 osu! 2024-07-30 at 09 00 41

@smoogipoo
Copy link
Contributor

(Based on the screenshots, read below): Imo the missing timestamps look like a bug.

That aside, this doesn't look to be working for me? I sat in #osu on non-development server and I only have one timestamp at the top of the chat box. Same for every other channel.

@peppy
Copy link
Member Author

peppy commented Jul 30, 2024

Imo the missing timestamps look like a bug.

I dunno, does it feel like less of a "bug" if the background doesn't extend?

2024-07-30 22 03 11@2x
2024-07-30 22 03 41@2x

That aside, this doesn't look to be working for me? I sat in #osu on non-development server and I only have one timestamp at the top of the chat box. Same for every other channel.

Fixed, silly oversight in recent changes.

@smoogipoo
Copy link
Contributor

I dunno, does it feel like less of a "bug" if the background doesn't extend?

No, I don't think so. I like the background extending the whole way, actually...

I mean, I'll roll with it to see what the community feedback is like but I don't really understand the necessity. If you're trying to match discord compact mode, then that one is grouped by user, which you could argue actually makes sense but isn't really applicable for us because our ratio of unique people is very high:
image

@peppy
Copy link
Member Author

peppy commented Jul 30, 2024

I'm trying to reduce clutter in general. This is how I used to have my IRC client setup and may be a personal preference.

Willing to change to match discord if people have issue with it though.

Copy link
Contributor

@smoogipoo smoogipoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guess we'll see how it turns out

@smoogipoo smoogipoo merged commit 13669fe into ppy:master Jul 30, 2024
11 of 13 checks passed
@peppy peppy deleted the chat-less-username-truncation branch July 31, 2024 07:24
@okawaffles
Copy link

is it possible we can get an option to change the font size?

@peppy
Copy link
Member Author

peppy commented Aug 1, 2024

You can adjust "ui scale" in settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants