Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mod preset tooltip's description text being cut off #29166

Conversation

normalid-awa
Copy link
Contributor

@normalid-awa normalid-awa commented Jul 28, 2024

Fix the visual bug of the mod preset tooltip's description text being cut off

The tooltip was first introduced in (#28650)
Master image
PR image

Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say the text should line break rather than stick out like that. Use a TextFlowContainer instead.

@normalid-awa
Copy link
Contributor Author

normalid-awa commented Jul 29, 2024

Latest commit:
image

@bdach bdach changed the title Fix mod preset tooltip's descriptions text being cut off Fix mod preset tooltip's description text being cut off Jul 29, 2024
@bdach bdach self-requested a review July 29, 2024 13:13
@bdach bdach merged commit 12e553a into ppy:master Jul 29, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants