Alternate background colour of chat lines to better visually distinguish wrapped lines

[normalid-awa]

Resolved: #29129 (first bullet point)

Master
PR

For better accessibility, altering the chat message background color with the message id, unit test were added

[peppy]

Doesn't look great. Would need some design input if we're going to do this. Also the corners of the highlight should probably be rounded, and the rows with no change to colour should probably not create needless drawables.

[normalid-awa]

Doesn't look great. Would need some design input if we're going to do this. Also the corners of the highlight should probably be rounded, and the rows with no change to colour should probably not create needless drawables.

would go something like this?

added a little smoothness to the mask and made the box round

[bdach]

paging @arflyte

[peppy]

With less rounding sure.

Apply the other changes I proposed and I'll fix up the visuals.

(I don't think this needs flyte input)

[normalid-awa]

With less rounding sure.

Apply the other changes I proposed and I'll fix up the visuals.

(I don't think this needs flyte input)

The changes were done, the rest is the visual

[peppy]

Made some visual and behavioural changes.

[normalid-awa]

omg, I didn't notice altering and alternating are two meanings.
Also, may I rename the unit test TestBackgroundAltering to TestChatlineBackgroundAlternating?It seems to make more sense and descriptive

[peppy]

omg, I didn't notice altering and alternating are two meanings. Also, may I rename the unit test TestBackgroundAltering to TestChatlineBackgroundAlternating?It seems to make more sense and descriptive

Good catch, I've fixed that.

[bdach]

This looks so weak on dark backgrounds it may as well be imperceptible.

On daily challenge screen:

In chat overlay:

Unless there is a follow-up change to change daily challenge screen chat to have a lighter background, I don't think this fully achieves what it claims it does.

[peppy]

Might depend on screen gamma, since it doesn't look too bad here.

To improve the situation, we'll probably want to turn off additive blending and choose a more appropriate colour (white doesn't work well at higher opacities). I'll have a fiddle.

[peppy]

I think this is feeling okay now, although there's some awkward overlap (admittedly was already an issue):

I'll see what I can do about that while I'm here.

[peppy]