-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a bunch of rhythm difficulty calculation fixes #28871
Conversation
!diffcalc |
!diffcalc |
Difficulty calculation failed: https://github.com/ppy/osu/actions/runs/10018306415 |
…bpm, adjust balancing
…difficulty of the next object, adjust balancing
…stent between rates
…dd nerf for ratios with delta difference fractions that are too big, adjust consts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@smoogipoo this change is good to go |
Co-authored-by: James Wilson <[email protected]>
?_? i guess i'm going to merge #29998 into this instead if that is the case, after #29980 (comment) sheet is done |
Any reason for waiting on the sheet? I only requested a sheet to be queued, but is not required for merge. |
well i mean if i run a sheet for the sake of running the sheet i can, but given that this touches the same code the preceding pull touched, it would make sense to verify that one doesn't do anything obviously broken before going forward? or not? but in that case we might as well run one sheet at the end of everything? this is a complete mess to manage. |
If you're expecting branches to be working 100% as expected from the get-go, then sheets must look good before merge with no exceptions. But, as we discussed, I'm fine not doing that in order to keep things moving at a rapid pace. My only requirement is for a sheet to be queued for each PR. It leaves a bit of a paper trail, if not to figure out where things went wrong / if a change has some edge case that was not known during rapid-merge, then to potentially be referenced if numbers are required to understand the change. I will check every sheet myself, it's just for my own sanity :) |
!diffcalc |
Queueing again with explicit !diffcalc |
This PR addresses a couple of rhythm evaluation issues in osu!:
Values can be checked here