Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the current activity when the multiplayer room updates #26343

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

adryzz
Copy link
Contributor

@adryzz adryzz commented Jan 2, 2024

Currently, if you create a multiplayer room and change its name from the default, the current user activity does not reflect that change, as seen in the Discord presence.
image

This same behavior occurs with playlists too, but i wasn't able to find a way fix it in PlaylistsRoomSubScreen because playlists are set as not editable

public PlaylistsRoomSubScreen(Room room)
: base(room, false) // Editing is temporarily not allowed.

Ideally should be done at the RoomSubScreen level, but since both PlaylistsRoomSubScreen and MultiplayerRoomSubScreen handle the activity themselves in their constructors, i didn't wanna change that

@peppy peppy self-requested a review January 3, 2024 04:07
Copy link
Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably harmless enough.

@peppy peppy merged commit e4ba7b8 into ppy:master Jan 3, 2024
10 of 11 checks passed
@adryzz adryzz deleted the fix-discord-multiplayer-presence branch January 3, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants