Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dropdown colour not updating correctly on enabled state changes #26207

Merged
merged 2 commits into from
Dec 29, 2023
Merged

Fix dropdown colour not updating correctly on enabled state changes #26207

merged 2 commits into from
Dec 29, 2023

Conversation

frenzibyte
Copy link
Member

Also changes the visual look of a disabled dropdown to match with other UI components (applying 0.3 alpha).

Before:

CleanShot 2023-12-29 at 05 33 38@2x

After:

CleanShot 2023-12-29 at 05 34 32@2x

@bdach bdach self-requested a review December 29, 2023 13:04
@bdach bdach merged commit f80f6a8 into ppy:master Dec 29, 2023
13 of 17 checks passed
@frenzibyte frenzibyte deleted the fix-dropdown-colour branch December 29, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdach bdach bdach approved these changes

Assignees
No one assigned
Labels
size/XS type:cosmetic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dropdowns change color unexpectedly when disabled (or vice-versa)
2 participants
@frenzibyte @bdach