Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cycle between Daycore and Half Time mod when using classic hotkeys style #26162

Merged
merged 2 commits into from
Dec 27, 2023

Conversation

Gabixel
Copy link
Contributor

@Gabixel Gabixel commented Dec 27, 2023

Even though this mod is not in Stable, it seems fair that it reflects the same behavior as Double Time and Nightcore using the classic hotkeys.

I noticed it a few days ago when I tried to switch between the two and found no match. It must have been lost over time with the added distinction of the two hotkey styles (or maybe even earlier, during the mod select redesign).

I see that there's already a test for this, so I guess there's no need to edit it or add some(?)

(Since this is my first contribution with pull requests here, I hope I don't make any weird mistakes. Or maybe I'm just too paranoid)

@bdach bdach changed the title Alternate Daycore with Half Time mod using classic hotkeys style Cycle between Daycore and Half Time mod when using classic hotkeys style Dec 27, 2023
Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, why not

@bdach bdach merged commit 10106e2 into ppy:master Dec 27, 2023
11 of 17 checks passed
@Gabixel Gabixel deleted the alternate-daycore-with-classic-hotkey branch December 28, 2023 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants