Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use classic HP values for non-classic osu! HP drain #26012

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented Dec 21, 2023

The main issue here, is that the default HP increase of LargeTickHit, as defined by Judgement, is equal to that of a Great. This seems to be way too lenient on slider-heavy maps.

But, the path I took to fixing this is via adding an OsuHealthProcessor that uses the same raw values as OsuLegacyHealthProcessor. It means that some values and their relative increases are a bit different and may need further adjustment.

Here's a few replays:

Replays.zip

The Izutsumi and Crone replays fail now but both players indicated their scores shouldn't have been passes.

I still don't think that my replay should be a fail, and it feels about as harsh as if not worse than classic mod now, but I want to get this out for wider feedback before further adjustments are made.

@bdach
Copy link
Collaborator

bdach commented Dec 22, 2023

So I suppose this is geared towards the "lazer drain too lenient, stable-like drain too harsh" feedback, right? If so, that does seem to achieve this behaviour.

I'm not sure I'm qualified to comment further, this probably needs playtesting, so I'm okay with getting that out, but not comfortable enough to click the button myself without at least a quick double check.

@bdach bdach requested a review from peppy December 22, 2023 08:27
@smoogipoo
Copy link
Contributor Author

Yeah, pretty much. Take this as restoring sane values but not fixing all issues, and potentially even making edge cases worse.

@peppy peppy merged commit 3f6dad5 into ppy:master Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants