Use classic HP values for non-classic osu! HP drain #26012
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main issue here, is that the default HP increase of
LargeTickHit
, as defined byJudgement
, is equal to that of aGreat
. This seems to be way too lenient on slider-heavy maps.But, the path I took to fixing this is via adding an
OsuHealthProcessor
that uses the same raw values asOsuLegacyHealthProcessor
. It means that some values and their relative increases are a bit different and may need further adjustment.Here's a few replays:
Replays.zip
The
Izutsumi
andCrone
replays fail now but both players indicated their scores shouldn't have been passes.I still don't think that my replay should be a fail, and it feels about as harsh as if not worse than classic mod now, but I want to get this out for wider feedback before further adjustments are made.