Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust "classic" mod multiplier to 0.96x #25934

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

peppy
Copy link
Member

@peppy peppy commented Dec 20, 2023

Following discussions on discord, this seems like the most agreed upon value. Increasing this is important so that imported legacy scores don't lose too much value.

Following discussions on discord, this seems like the most agreed upon
value. Increasing this is important so that imported legacy scores don't
lose too much value.
@bdach
Copy link
Collaborator

bdach commented Dec 20, 2023

Just to confirm because I didn't realise this last time for whatever reason (good reviewing me, well done):

This is applied at ModClassic level, so this means that the 0.96x multiplier will hold across all rulesets, not just osu!. And most arguments for multiplier concerned slider head accuracy, which is an osu!-specific concern.

In light of that, are we confident that the placement of this multiplier is correct?

@peppy
Copy link
Member Author

peppy commented Dec 20, 2023

I think across all rulesets is best for the initial release. We can tweak as required, once we have leaderboards to work with.

@peppy peppy requested a review from smoogipoo December 20, 2023 07:47
@smoogipoo smoogipoo merged commit 188c463 into ppy:master Dec 20, 2023
@peppy peppy deleted the adjust-classic-mod-multiplier branch December 22, 2023 06:03
@april83c
Copy link

What if the multiplier was different depending on which options of the Classic mod you actually have selected — e.g. if you disable "No slider head accuracy requirement"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

4 participants