Fix crash when creating collections named "All beatmaps" or "Manage collections..." #25839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
added
type:reliability
next release
peppy
reviewed
Dec 18, 2023
|
|
||
| public override bool Equals(CollectionFilterMenuItem? other) => other is AllBeatmapsCollectionFilterMenuItem; | ||
|
|
||
| public override int GetHashCode() => 1; |
There was a problem hiding this comment.
scary but i'll assume there's some theory behind this.
There was a problem hiding this comment.
The way to think about it is as such: if two objects are equal, they must have the same hash code, but two objects with the same hash code are not necessarily equal.
So a constant hash code spec such as this ensures that all instances of the class have the same hash code, and since the equality member only checks type, this satisfies the first part.
There is no actual data to base the hash code implementation on. If anything it'll just be a little inefficient in a dictionary, but the assumption is that there's only ever going to be one of these per dropdown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25834
The name fallback that was there previously since #11892 was half broken. This way should be a lot less prone to failure.