Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package .json files in nupkg output #18319

Merged
merged 1 commit into from
May 18, 2022
Merged

Conversation

smoogipoo
Copy link
Contributor

As mentioned in #18318 (comment)

It isn't really required for us, but might as well have it I suppose?

This .nuspec file is kinda dodgy and only seems to work because osu-deploy is using nuget.exe as opposed to dotnet pack, so I'm following existing examples without changing the things that look glaringly wrong.

Note: I can't get dotnet pack to work favourably at all, so not investigating that for now.

Testing with:

cd osu.Desktop
rm -r out
dotnet publish -c:Release -r:win-x64 -o out
nuget pack osu.nuspec -BasePath out

@peppy peppy merged commit e652180 into ppy:master May 18, 2022
@smoogipoo smoogipoo deleted the package-json-files branch September 11, 2023 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants