Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beatmap imports using the local cache lookup do not get a submitted / ranked date populated #22416

Closed
Loreos7 opened this issue Jan 25, 2023 · 10 comments · Fixed by ppy/osu-onlinedb-generator#8 or #29553
Assignees
Labels
priority:1 Very important. Feels bad without fix. Affects the majority of users. realm deals with local realm database

Comments

@Loreos7
Copy link
Contributor

Loreos7 commented Jan 25, 2023

Type

Game behaviour

Bug description

(Title). Works the same with Date Ranked sorting criteria.

Beatmap: https://osu.ppy.sh/beatmapsets/25861#osu/92939

Screenshots or videos

2023-01-25.16-02-23.mp4

Version

123

Logs

@Loreos7 Loreos7 changed the title Beatmap doesn't show up in song select if date submitted sorting set Beatmap's card doesn't show up in song select if date submitted sorting set Jan 25, 2023
@Loreos7 Loreos7 changed the title Beatmap's card doesn't show up in song select if date submitted sorting set Beatmapset's card doesn't show up in song select if date submitted sorting set Jan 25, 2023
@Theighlin
Copy link

Theighlin commented Jan 25, 2023

I can see said beatmap even with the date submitted sorting
image

But i'm more curious on why at the end of the video the game seems to show every beatmap you have as updateable?

Also, you should've posted logs, as requested in the issue template

@Loreos7
Copy link
Contributor Author

Loreos7 commented Jan 25, 2023

@Loreos7
Copy link
Contributor Author

Loreos7 commented Jan 25, 2023

The issue was resolved by deleting online.db file.

@Loreos7 Loreos7 closed this as completed Jan 25, 2023
@bdach
Copy link
Collaborator

bdach commented Jan 25, 2023

The issue was resolved by deleting online.db file.

I'm... not sure that is an acceptable fix. Do you recall how the map might have been imported?

These symptoms may indicate that there's a gap somewhere in the metadata population flow that we may need to address.

@Loreos7 Loreos7 reopened this Jan 26, 2023
@Loreos7
Copy link
Contributor Author

Loreos7 commented Jan 26, 2023

@bdach You're right.
I can reproduce this issue again. I downloaded the beatmapset through the web, imported to osu!stable client, then imported it through Setup wizard in lazer.

2023-01-26.03-09-38.mp4

@Loreos7 Loreos7 changed the title Beatmapset's card doesn't show up in song select if date submitted sorting set Beatmapset's card that was imported from stable doesn't show up in song select if date submitted sorting set Jan 26, 2023
@peppy peppy added realm deals with local realm database priority:1 Very important. Feels bad without fix. Affects the majority of users. labels Jan 26, 2023
@peppy
Copy link
Member

peppy commented Jan 26, 2023

// TODO: DateSubmitted and DateRanked are not provided by local cache.

To make this work, the local lookup database needs osu_beatmapsets in addition to osu_beatmaps.

@peppy peppy changed the title Beatmapset's card that was imported from stable doesn't show up in song select if date submitted sorting set Beatmap imports using the local cache lookup do not get a submitted / ranked date popuplated Jan 26, 2023
@peppy peppy changed the title Beatmap imports using the local cache lookup do not get a submitted / ranked date popuplated Beatmap imports using the local cache lookup do not get a submitted / ranked date populated Jan 27, 2023
@huyenden

This comment was marked as off-topic.

@StarBleu1
Copy link

Not sure whether this counts as this issue or other one
Sorting by Date ranked, Date submitted and Date added doesnt seem to work at all for maps imported from stable.

Video for reference: https://streamable.com/0w1r6w
Gamever: 2024.817.0-lazer
1724241695.performance.log
1724241695.database.log
1724241695.updater.log
1724241695.runtime.log
1724241695.network.log

@bdach
Copy link
Collaborator

bdach commented Aug 21, 2024

It'll be invariably caused by this issue, yes.

@huyenden
Copy link

Not sure whether this counts as this issue or other one Sorting by Date ranked, Date submitted and Date added doesnt seem to work at all for maps imported from stable.

For 2 years now I still think this is the biggest bug because the most useful lazer function which is date ranked doesn't work properly because of importing maps from Stable.

One of the ways I used to fix the error is https://github.com/molneya/osu_db_helpers. To update date added in stable to date ranked. Then enter map in lazer.

This way will bypass the error that causes lazer to still record date ranked as date added. But still can not avoid the original error.

Hope @bdach considers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:1 Very important. Feels bad without fix. Affects the majority of users. realm deals with local realm database
Projects
None yet
6 participants