Skip to content

Commit

Permalink
Merge pull request #29710 from bdach/silence-favourite-button-errors
Browse files Browse the repository at this point in the history
Silence beatmap retrieval failures from results screen favourite button
  • Loading branch information
peppy authored Sep 6, 2024
2 parents 925710d + 9f834ca commit a912d86
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion osu.Game/Screens/Ranking/FavouriteButton.cs
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,13 @@ private void getBeatmapSet()
};
beatmapSetRequest.Failure += e =>
{
Logger.Error(e, $"Failed to fetch beatmap info: {e.Message}");
Logger.Log($"Favourite button failed to fetch beatmap info: {e}", LoggingTarget.Network);

Schedule(() =>
{
loading.Hide();
Enabled.Value = false;
TooltipText = "this beatmap cannot be favourited";
});
};
api.Queue(beatmapSetRequest);
Expand Down

0 comments on commit a912d86

Please sign in to comment.