-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ANZT6W
tournament page
#12616
base: master
Are you sure you want to change the base?
Add ANZT6W
tournament page
#12616
Conversation
Someone else has edited same files as you did. Please check their changes in case they conflict with yours: |
ab1b27c
to
5063b24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When adding a tournament to the tournament listings in other languages, make sure to adjust the date formats. They're currently all using the English format.
I suggest adding all ANZT tournaments to the index page and tournament listings in this PR already. Once the full articles are PR'd, you then only need to add in the links. This will also avoid any merge conflicts that arise when doing multiple PR's for the same index page.
I will also suggest doing a new PR for each tournament, or PR's for each year (so bundle the summer and winter tournaments). Large PR's with tons of tournaments all at once are a daunting task to review. By separating them into smaller chunks, they can be reviewed and taken care of 1 by 1. Divide and Conquer type of deal.
6980aca
to
f5a3a58
Compare
c2d1385
to
b475979
Compare
b475979
to
0c6e484
Compare
@Albionthegreat Thanks for the feedback. I've:
I'll follow your advice and use smaller PRs for each tournament or two. Apologies for all the force pushes, hopefully that's not an issue. |
Just to clarify, this PR is ready for anyone to review it. I'm done making changes for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take a look at the tournament page itself later. The listings and index pages look good!
b21dfe8
to
a9112d1
Compare
Thanks for the feedback @Albionthegreat. I've incorporated all your suggestions. Looks like I'm outdated on new styling since I was last here 6-7 years ago. |
This PR adds an article for the ANZT6W tournament.
There have been a bunch of ANZT tournaments since this one that are undocumented in this wiki. I'm planning on documenting them all in one big pull request in the future. Let me know if that's not a good idea. They are:This PR also adds entries on the tourney index page and ANZT tourney index page for all following tournaments after 6W. They are:
Self-check