Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ANZT6W tournament page #12616

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

JWWolstenholme
Copy link
Contributor

@JWWolstenholme JWWolstenholme commented Dec 29, 2024

This PR adds an article for the ANZT6W tournament.

There have been a bunch of ANZT tournaments since this one that are undocumented in this wiki. I'm planning on documenting them all in one big pull request in the future. Let me know if that's not a good idea. They are:

This PR also adds entries on the tourney index page and ANZT tourney index page for all following tournaments after 6W. They are:

Self-check

@JWWolstenholme JWWolstenholme changed the title Tournaments/anzt Add ANZT6W tournament page Dec 29, 2024
@JWWolstenholme JWWolstenholme marked this pull request as ready for review December 29, 2024 14:52
@JWWolstenholme JWWolstenholme changed the title Add ANZT6W tournament page Add ANZT6W tournament page Dec 29, 2024
Copy link

Someone else has edited same files as you did. Please check their changes in case they conflict with yours:

Copy link
Contributor

@Albionthegreat Albionthegreat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When adding a tournament to the tournament listings in other languages, make sure to adjust the date formats. They're currently all using the English format.

I suggest adding all ANZT tournaments to the index page and tournament listings in this PR already. Once the full articles are PR'd, you then only need to add in the links. This will also avoid any merge conflicts that arise when doing multiple PR's for the same index page.

I will also suggest doing a new PR for each tournament, or PR's for each year (so bundle the summer and winter tournaments). Large PR's with tons of tournaments all at once are a daunting task to review. By separating them into smaller chunks, they can be reviewed and taken care of 1 by 1. Divide and Conquer type of deal.

@JWWolstenholme JWWolstenholme force-pushed the tournaments/anzt branch 2 times, most recently from c2d1385 to b475979 Compare March 2, 2025 13:16
@JWWolstenholme
Copy link
Contributor Author

@Albionthegreat Thanks for the feedback. I've:

  • Corrected the dates on the translated pages using the changes you suggest
  • Added entries, but not dead links, to all the other ANZT tourneys since 6W.
    • I made sure to follow each translation's date format.
  • Rebased this PR onto master since I've left this PR sitting for so long

I'll follow your advice and use smaller PRs for each tournament or two. Apologies for all the force pushes, hopefully that's not an issue.

@JWWolstenholme
Copy link
Contributor Author

JWWolstenholme commented Mar 2, 2025

I've also included entries for tourneys 1 through 4 which were already included in the main tourney index page, but missing from the ANZT tourney index page. Forum links:

@JWWolstenholme
Copy link
Contributor Author

Just to clarify, this PR is ready for anyone to review it. I'm done making changes for now.

Copy link
Contributor

@Albionthegreat Albionthegreat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take a look at the tournament page itself later. The listings and index pages look good!

JWWolstenholme added a commit to JWWolstenholme/osu-wiki that referenced this pull request Mar 13, 2025
JWWolstenholme added a commit to JWWolstenholme/osu-wiki that referenced this pull request Mar 13, 2025
@JWWolstenholme
Copy link
Contributor Author

JWWolstenholme commented Mar 13, 2025

Thanks for the feedback @Albionthegreat. I've incorporated all your suggestions.

Looks like I'm outdated on new styling since I was last here 6-7 years ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants