Refactor HitResult generation to make ruleset-specific behavior more explicit #231
+11
−31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before you had function
GenerateHitResults(double accuracy, IBeatmap beatmap, int countMiss, int? countMeh, int? countGood)
, where you passcountMiss
,countMeh
andcountGood
.So by function signature you may assume that it's using those 3 judgements to generate hitresults.
In reality - osu also used
largeTickMisses
andsliderTailMisses
from class itself, mania usedoks
andgreats
from class, when taiko just ignoredcountMeh
because it doesn't exist in taiko. What is quite confusing and unintuitive.This PR removes those params from basic
GenerateHitResults
, so it would be intuitive that all values are taken from attributes of the class.And then this function delegates calculation to ruleset-specific static function that takes correct parameters.
Prerequisite for #232