Stop tracking build user counts when shutting down #206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://discord.com/channels/188630481301012481/188630652340404224/1186195069062094918
Simplest feasible solution.
I also considered making
BuildCountUserUpdater
implementIEntityStore
but it's a stretch. It doesn't really track entities, so two out of three members of the interface don't make sense for the class. You could split the one method that does to an interface, but at that point the split-out interface would become a cheap copy ofIDisposable
anyways.Can be tested via something like the following (probably won't apply directly due to the
REPLAYS_PATH
I have set locally):