Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transitive vulnerable dependencies for source generation tests #6435

Merged
merged 6 commits into from
Dec 3, 2024

Conversation

huoyaoyuan
Copy link
Contributor

@huoyaoyuan huoyaoyuan commented Nov 27, 2024

The updated packages were bringing vulnerable dependencies like NETStandard.Libraries and NuGet.Common. This will cause visible warnings when building inside VS or command line with .NET 9 SDK.

The compiler packages are updated to 4.8.0, which is the lowest version that's capable to compile targeting .NET 8.

Unfortunately, the test driver package are having behavioral breaking changes, which are not hard to resolve.

Running fine with VS 17.12. Please verify IDE compatibility with Rider/VSCode.

peppy
peppy previously approved these changes Nov 28, 2024
Copy link
Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine with rider / .NET 8 for me

smoogipoo
smoogipoo previously approved these changes Nov 28, 2024
Copy link
Contributor

@smoogipoo smoogipoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work

@peppy peppy requested review from peppy and removed request for peppy November 28, 2024 08:53
@peppy peppy dismissed stale reviews from smoogipoo and themself via 7fa6a01 November 28, 2024 09:00
@smoogipoo smoogipoo merged commit f3f3f4a into ppy:master Dec 3, 2024
12 of 14 checks passed
@huoyaoyuan huoyaoyuan deleted the vulnerable-dependency branch December 3, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants