Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce string allocations during shader creation #6121

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Reduce string allocations during shader creation #6121

merged 3 commits into from
Jan 11, 2024

Conversation

peppy
Copy link
Member

@peppy peppy commented Jan 10, 2024

Before After
2024-01-11 05 19 21@2x 2024-01-11 05 19 17@2x

@bdach bdach self-requested a review January 11, 2024 11:54
@bdach bdach enabled auto-merge January 11, 2024 12:07
@peppy peppy disabled auto-merge January 11, 2024 12:21
@peppy peppy merged commit 450946d into ppy:master Jan 11, 2024
19 of 21 checks passed
@peppy peppy deleted the shader-compile-alloc branch January 17, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbedi turbedi turbedi left review comments

@bdach bdach bdach approved these changes

Assignees
No one assigned
Labels
size/M type:performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peppy @turbedi @bdach