Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add window hide/show methods (preliminary work for boss key) #6085

Merged
merged 2 commits into from
Jan 1, 2024
Merged

add window hide/show methods (preliminary work for boss key) #6085

merged 2 commits into from
Jan 1, 2024

Conversation

adryzz
Copy link
Contributor

@adryzz adryzz commented Dec 23, 2023

Preliminary work for ppy/osu#6790.

Tested on Windows, MacOS and Linux (X11/Wayland), and doesn't work on MacOS (tracked upstream libsdl-org/SDL#8216)

@smoogipoo
Copy link
Contributor

Does this transfer focus? Any reason we should be using Show() over Raise()?

@adryzz
Copy link
Contributor Author

adryzz commented Dec 30, 2023

I tested Raise() and on the KDE wayland session at least, the window does not raise, as it is hidden.

@smoogipoo smoogipoo enabled auto-merge December 31, 2023 02:09
@adryzz
Copy link
Contributor Author

adryzz commented Jan 1, 2024

Failed CanSeekForwardsOnInterpolationFail

i don't think this has anything to do with this PR

@smoogipoo smoogipoo merged commit 58246ae into ppy:master Jan 1, 2024
@adryzz adryzz deleted the window-hide-show branch January 1, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoogipoo smoogipoo smoogipoo approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adryzz @smoogipoo