IncrementalBSplineBuilder: rewrite algorithm with many improvements #6047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The BSpline builder now smoothens the input curve before processing it - Corners are detected explicitly based on local maxima of winding rate - The density of control points is also determined by winding rate
bdach
reviewed
Nov 15, 2023
| @@ -31,7 +31,7 @@ public static class PathApproximator | |||
| /// <returns>A list of vectors representing the piecewise-linear approximation.</returns> | |||
| public static List<Vector2> BezierToPiecewiseLinear(ReadOnlySpan<Vector2> controlPoints) | |||
| { | |||
| return BSplineToPiecewiseLinear(controlPoints, controlPoints.Length - 1); | |||
| return BSplineToPiecewiseLinear(controlPoints, Math.Max(1, controlPoints.Length - 1)); | |||
bdach
approved these changes
Nov 16, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on PathApproximator: no BSpline degree <1 and better special case handling #6045
The BSpline builder now smoothens the input curve before processing it, making it more reliable.
Corners are detected explicitly based on local maxima of winding rate. To be automatically converted to red control points on osu!'s end.
The density of control points is also determined by winding rate.
Fixes #6046 and addresses comments in ppy/osu#25409
Screen.Recording.2023-11-14.at.13.32.04.mov