Beginnings of better logging tests.#68
Closed
pp-mo wants to merge 1 commit intotest_logging_plus_BASISfrom
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the standard
unittest.TestCase.assertLogsmethod to also exercise the formatting for the messages.This was in response to problems in Iris testing, see : SciTools#4106
The key problem is that using
assertLogsdoesn't actually do what the 'real' loggin operation does, so misses code coverage and possible bugs.I'm still not really convinced that this covers everything that might go wrong in the 'real' logging operation, but I think that it at least helps. It seems that the 'extra format' is perhaps the main configurable part of logger operation, and this exercises the formatter code. What meanwhile might go wrong with any of the attached handlers is not quite so clear : we still aren't exercising those, but if run they would write to files / terminal etc, which we don't want within testing.