Better calculations for MeshCoord points and bounds [AVD-1590].#67
Closed
Better calculations for MeshCoord points and bounds [AVD-1590].#67
Conversation
pp-mo
force-pushed
the
meshcoord_fullcalc
branch
from
3c3aadc to
d6bdb1d
Compare
pp-mo
changed the title
pp-mo
force-pushed
the
meshcoord_fullcalc
branch
from
d6bdb1d to
56a1259
Compare
* Add MeshCoord with basic tests. * Revised __init__; fixed copy mechanisms. Still WIP. * Apply suggestions from code review Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com> * Review changes. * Rethink getitem and copy; test points and bounds results. * Fix for changed API on rebase. * Review changes. * Review changes. * Adjust equality behaviour, and test it. * Tiny fix. Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com>
pp-mo
force-pushed
the
meshcoord_fullcalc
branch
from
56a1259 to
bcb94f6
Compare
pp-mo
force-pushed
the
meshcoord_fullcalc
branch
from
e026899 to
efb6ce1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed on top of SciTools#4036, to provide fully working points+bounds calculations.
WIP for now : probably wait until SciTools#4036 settles before considering whether this will need rebasing or re-targetting