Network modification. Replace threeWindingsTransformers by 3 twoWindingsTransformers and vice versa #3167

marqueslanauja · 2024-10-02T14:00:54Z

Please check if the PR fulfills these requirements

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

Feature

This PR contains two network modification methods.
The first one, replaces all the ThreeWindingsTransformers of the network by 3 equivalent TwoWindingsTransformers. In this process:

A new voltage level is created for the star node with ratedU0 as nominal voltage.
3 new TwoWindingsTransformers are created. One for each leg of the removed ThreeWindingsTransformer.
The following attributes are mapped, copied or adjusted:
- Electrical characteristics, ratioTapChangers, and phaseTapChangers. (No adjustments are required)
- Operational Loading Limits.
- Controllers using any of the ThreeWindingsTransformer terminals as regulatingTerminals.
- Active and reactive power of the ThreeWindingsTransformer terminals.
- Aliases for known CGMES identifiers (terminal, transformer end, ratio and phase tap changer).
- Properties, 3-wt star bus voltage and angle, operational limit names.
- Extensions (only IIDM extensions are considered), TransformerFortescueData, PhaseAngleClock, and TransformerToBeEstimated
Properties, aliases and extensions not mapped are recorded in the functional log (report nodes).
New and removed equipment is also recorded in the functional log.

The second one, replaces all the 3 TwoWindingsTransformers of the network by an equivalent ThreeWindingsTransformer. In this process:

BusbarSections and the 3 TwoWindingsTransformers are the only connectables allowed In the voltageLevel associated with the star bus.
A new ThreeWindingsTransformer is created for replacing the 3 TwoWindingsTransformers.
The following attributes are mapped, copied or adjusted:
- RatedU0 is set to the nominal voltage of the star voltage level.
- Electrical characteristics, ratioTapChangers, and phaseTapChangers. Adjustments are required if TwoWindingsTransformers are not well oriented (End2 must be on the star side).
- Operational Loading Limits.
- Controllers using any of the ThreeWindingsTransformer terminals as regulatingTerminals.
- Active and reactive power of the ThreeWindingsTransformer terminals.
- Aliases for known CGMES identifiers (terminal, transformer end, ratio and phase tap changer).
- Properties: star bus voltage and angle are added as properties, and operational limit names are copied.
- Extensions (only IIDM extensions are considered), TransformerFortescueData, PhaseAngleClock, and TransformerToBeEstimated
Properties, aliases and extensions not mapped are recorded in the functional log (report nodes).
New and removed equipment is also recorded in the functional log.

In both processes, internal connections are created to manage the replacement.

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

Yes
No

If yes, please check if the following requirements are fulfilled

The Breaking Change or Deprecated label has been added
The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Custom IIDM implementation maintainers should implement the following method in their RemoteReactivePowerControl implementations:

RemoteReactivePowerControl setRegulatingTerminal(Terminal regulatingTerminals);

Other information:

…ngsTranformers and vice versa. Signed-off-by: marquesja1 <[email protected]>

Signed-off-by: marquesja1 <[email protected]>

…ansformers_by_3_twoWindingsTransformers

Signed-off-by: marquesja1 <[email protected]>

…ansformers_by_3_twoWindingsTransformers

...owsybl/iidm/modification/Replace3TwoWindingsTransformersByThreeWindingsTransformersTest.java

...extensions/src/main/java/com/powsybl/iidm/network/extensions/RemoteReactivePowerControl.java

...owsybl/iidm/modification/ReplaceThreeWindingsTransformersBy3TwoWindingsTransformersTest.java

Signed-off-by: marquesja1 <[email protected]>

...om/powsybl/iidm/modification/ReplaceThreeWindingsTransformersBy3TwoWindingsTransformers.java

...owsybl/iidm/modification/Replace3TwoWindingsTransformersByThreeWindingsTransformersTest.java

Signed-off-by: marquesja1 <[email protected]>

…ansformers_by_3_twoWindingsTransformers

iidm/iidm-modification/src/main/java/com/powsybl/iidm/modification/util/TransformerUtils.java

...om/powsybl/iidm/modification/Replace3TwoWindingsTransformersByThreeWindingsTransformers.java

...om/powsybl/iidm/modification/ReplaceThreeWindingsTransformersBy3TwoWindingsTransformers.java

...om/powsybl/iidm/modification/Replace3TwoWindingsTransformersByThreeWindingsTransformers.java

olperr1 · 2024-11-15T09:58:06Z

...om/powsybl/iidm/modification/ReplaceThreeWindingsTransformersBy3TwoWindingsTransformers.java

+            } else if (t2wLeg3.getOperationalLimitsGroups1().stream().anyMatch(operationalLimitsGroup -> propertyName.contains(operationalLimitsGroup.getId()))) {
+                t2wLeg3.setProperty(propertyName, property);
+            } else {
+                copied = false;


I think all other properties should be copied on the 3 2wt.

Properties have a strong dependency on the propertyName. The propertyName is essential to use properly the property data. I'm not sure if copying properties with a general procedure, without adjusting their propertyNames will be the best option as the result will not be in general usable for exporting the model to the original format, the main use of the properties now, I think.

Properties are used to pass additional data on an identifiable. They may be used in a full IIDM context (without exporting the network in another format) and it can make sense to transfer them.

...om/powsybl/iidm/modification/ReplaceThreeWindingsTransformersBy3TwoWindingsTransformers.java

...ification/src/main/java/com/powsybl/iidm/modification/util/RegulatedTerminalControllers.java

…tion/Replace3TwoWindingsTransformersByThreeWindingsTransformers.java Co-authored-by: Olivier Perrin <[email protected]> Signed-off-by: marqueslanauja <[email protected]>

…tion/ReplaceThreeWindingsTransformersBy3TwoWindingsTransformers.java Co-authored-by: Olivier Perrin <[email protected]> Signed-off-by: marqueslanauja <[email protected]>

Signed-off-by: marquesja1 <[email protected]>

...om/powsybl/iidm/modification/Replace3TwoWindingsTransformersByThreeWindingsTransformers.java

...om/powsybl/iidm/modification/ReplaceThreeWindingsTransformersBy3TwoWindingsTransformers.java

Signed-off-by: marquesja1 <[email protected]>

sonarcloud · 2024-11-22T06:53:11Z

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
89.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

olperr1 · 2024-11-22T12:51:00Z

...om/powsybl/iidm/modification/Replace3TwoWindingsTransformersByThreeWindingsTransformers.java

+        ThreeWindingsTransformerAdder t3wAdder = substation.newThreeWindingsTransformer()
+                .setId(getId(twoR))


I think it would be safer to unsure that the new ID is unique. It could prevent exceptions during the network modification application:

Suggested change

ThreeWindingsTransformerAdder t3wAdder = substation.newThreeWindingsTransformer()

.setId(getId(twoR))

ThreeWindingsTransformerAdder t3wAdder = substation.newThreeWindingsTransformer()

.setEnsureIdUnicity(true)

.setId(getId(twoR))

olperr1 · 2024-11-22T12:52:07Z

...om/powsybl/iidm/modification/ReplaceThreeWindingsTransformersBy3TwoWindingsTransformers.java

+ *     <li>A new voltage level is created for the star node with nominal voltage of ratedU0.</li>
+ *     <li>Three new TwoWindingsTransformers are created, one for each leg of the removed ThreeWindingsTransformer.</li>
+ *     <li>The following attributes are copied from each leg to the new associated twoWindingsTransformer:</li>
+ *     <ul>


The nested <ul> tags should be inside their corresponding <li> tag.

Source: The HTML specification of the WHATWG:

ul tags should contain 0 or more li tags

li tags should contain ul, ol and/or menu tags

olperr1 · 2024-11-22T12:54:51Z

...om/powsybl/iidm/modification/ReplaceThreeWindingsTransformersBy3TwoWindingsTransformers.java

+        if (aliasType.equals("CGMES.TransformerEnd" + legEnd)) {
+            t2wLeg.addAlias(alias, "CGMES.TransformerEnd1");
+        } else if (aliasType.equals("CGMES.Terminal" + legEnd)) {
+            t2wLeg.addAlias(alias, "CGMES.Terminal1");
+        } else if (aliasType.equals("CGMES.RatioTapChanger" + legEnd)) {
+            t2wLeg.addAlias(alias, "CGMES.RatioTapChanger1");
+        } else if (aliasType.equals("CGMES.PhaseTapChanger" + legEnd)) {
+            t2wLeg.addAlias(alias, "CGMES.PhaseTapChanger1");
+        } else {


As for IDS, we should ensure the aliases are unique:

Suggested change

if (aliasType.equals("CGMES.TransformerEnd" + legEnd)) {

t2wLeg.addAlias(alias, "CGMES.TransformerEnd1");

} else if (aliasType.equals("CGMES.Terminal" + legEnd)) {

t2wLeg.addAlias(alias, "CGMES.Terminal1");

} else if (aliasType.equals("CGMES.RatioTapChanger" + legEnd)) {

t2wLeg.addAlias(alias, "CGMES.RatioTapChanger1");

} else if (aliasType.equals("CGMES.PhaseTapChanger" + legEnd)) {

t2wLeg.addAlias(alias, "CGMES.PhaseTapChanger1");

} else {

if (aliasType.equals("CGMES.TransformerEnd" + legEnd)) {

t2wLeg.addAlias(alias, "CGMES.TransformerEnd1", true);

} else if (aliasType.equals("CGMES.Terminal" + legEnd)) {

t2wLeg.addAlias(alias, "CGMES.Terminal1", true);

} else if (aliasType.equals("CGMES.RatioTapChanger" + legEnd)) {

t2wLeg.addAlias(alias, "CGMES.RatioTapChanger1", true);

} else if (aliasType.equals("CGMES.PhaseTapChanger" + legEnd)) {

t2wLeg.addAlias(alias, "CGMES.PhaseTapChanger1", true);

} else {

...om/powsybl/iidm/modification/Replace3TwoWindingsTransformersByThreeWindingsTransformers.java

olperr1 · 2024-11-22T12:59:34Z

...om/powsybl/iidm/modification/Replace3TwoWindingsTransformersByThreeWindingsTransformers.java

+        if (aliasType.equals("CGMES.TransformerEnd" + end)) {
+            t3w.addAlias(alias, "CGMES.TransformerEnd" + leg);
+        } else if (aliasType.equals("CGMES.Terminal" + end)) {
+            t3w.addAlias(alias, "CGMES.Terminal" + leg);
+        } else if (aliasType.equals("CGMES.RatioTapChanger1")) {
+            t3w.addAlias(alias, "CGMES.RatioTapChanger" + leg);
+        } else if (aliasType.equals("CGMES.PhaseTapChanger1")) {
+            t3w.addAlias(alias, "CGMES.PhaseTapChanger" + leg);
+        } else {


To avoid potential collisions which may cause a crash of the network modification application:

Suggested change

if (aliasType.equals("CGMES.TransformerEnd" + end)) {

t3w.addAlias(alias, "CGMES.TransformerEnd" + leg);

} else if (aliasType.equals("CGMES.Terminal" + end)) {

t3w.addAlias(alias, "CGMES.Terminal" + leg);

} else if (aliasType.equals("CGMES.RatioTapChanger1")) {

t3w.addAlias(alias, "CGMES.RatioTapChanger" + leg);

} else if (aliasType.equals("CGMES.PhaseTapChanger1")) {

t3w.addAlias(alias, "CGMES.PhaseTapChanger" + leg);

} else {

if (aliasType.equals("CGMES.TransformerEnd" + end)) {

t3w.addAlias(alias, "CGMES.TransformerEnd" + leg, true);

} else if (aliasType.equals("CGMES.Terminal" + end)) {

t3w.addAlias(alias, "CGMES.Terminal" + leg, true);

} else if (aliasType.equals("CGMES.RatioTapChanger1")) {

t3w.addAlias(alias, "CGMES.RatioTapChanger" + leg, true);

} else if (aliasType.equals("CGMES.PhaseTapChanger1")) {

t3w.addAlias(alias, "CGMES.PhaseTapChanger" + leg, true);

} else {

olperr1 · 2024-11-22T13:01:03Z

...om/powsybl/iidm/modification/ReplaceThreeWindingsTransformersBy3TwoWindingsTransformers.java

+                .newTwoWindingsTransformer()
+                .setId(t3w.getId() + "-Leg" + leg.getSide().getNum())


To avoid potential application crash due to an ID collision:

Suggested change

.newTwoWindingsTransformer()

.setId(t3w.getId() + "-Leg" + leg.getSide().getNum())

.newTwoWindingsTransformer()

.setEnsureIdUnicity(true)

.setId(t3w.getId() + "-Leg" + leg.getSide().getNum())

olperr1 · 2024-11-22T13:02:54Z

...om/powsybl/iidm/modification/Replace3TwoWindingsTransformersByThreeWindingsTransformers.java

+ *     <li>Each twoWindingsTransformer is well oriented if the star bus is located at the end 2.</li>
+ *     <li>A new ThreeWindingsTransformer is created for replacing the three TwoWindingsTransformers.</li>
+ *     <li>The following attributes are copied from each twoWindingsTransformer to the new associated leg:</li>
+ *     <ul>


The nested <ul> tags should be inside their corresponding <li> tag.

marqueslanauja and others added 15 commits October 2, 2024 15:55

Network modification. Replace threeWindingsTransformers by 3 twoWindi…

58ae352

…ngsTranformers and vice versa. Signed-off-by: marquesja1 <[email protected]>

Fix test error

5f7257d

Signed-off-by: marquesja1 <[email protected]>

Improve reportNode. Add reportNode tests.

17b60b6

Signed-off-by: marquesja1 <[email protected]>

RatioTapChanger, PhaseTapChanger, and LoadingLimits tests.

fd777bd

Signed-off-by: marquesja1 <[email protected]>

Alias test

3707772

Signed-off-by: marquesja1 <[email protected]>

Properties test.

cfb22f8

Signed-off-by: marquesja1 <[email protected]>

ControlledRegulatingTerminals test

4c74abd

Signed-off-by: marquesja1 <[email protected]>

Add flow tests.

729bd47

Signed-off-by: marquesja1 <[email protected]>

Fix issues

230aef6

Signed-off-by: marquesja1 <[email protected]>

Fix issues. Pretty code

aa3ffe7

Signed-off-by: marquesja1 <[email protected]>

Merge branch 'main' into network_modification_replace_threeWindingsTr…

9966da1

…ansformers_by_3_twoWindingsTransformers

Fix error

bdd8839

Signed-off-by: marquesja1 <[email protected]>

Add nodeBreaker test

07f158a

Signed-off-by: marquesja1 <[email protected]>

Fix new issues

0540077

Signed-off-by: marquesja1 <[email protected]>

Extensions. Copy and tests.

e23b54c

Signed-off-by: marquesja1 <[email protected]>

marqueslanauja requested a review from zamarrenolm October 7, 2024 14:28

marqueslanauja and others added 2 commits October 8, 2024 10:51

Star bus voltage and angle

1540924

Signed-off-by: marquesja1 <[email protected]>

Merge branch 'main' into network_modification_replace_threeWindingsTr…

eef7b0f

…ansformers_by_3_twoWindingsTransformers

zamarrenolm reviewed Oct 18, 2024

View reviewed changes

...owsybl/iidm/modification/Replace3TwoWindingsTransformersByThreeWindingsTransformersTest.java Show resolved Hide resolved

zamarrenolm reviewed Oct 18, 2024

View reviewed changes

...extensions/src/main/java/com/powsybl/iidm/network/extensions/RemoteReactivePowerControl.java Show resolved Hide resolved

zamarrenolm reviewed Oct 18, 2024

View reviewed changes

...owsybl/iidm/modification/ReplaceThreeWindingsTransformersBy3TwoWindingsTransformersTest.java Show resolved Hide resolved

Apply reviewer's comments

c4b3a71

Signed-off-by: marquesja1 <[email protected]>

marqueslanauja marked this pull request as ready for review October 21, 2024 05:54

marqueslanauja requested a review from rcourtier October 21, 2024 05:54

So-Fras added the December 2024 release label Oct 23, 2024

rcourtier requested changes Oct 24, 2024

View reviewed changes

marqueslanauja added 3 commits October 25, 2024 14:27

Apply reviewer's comments

ae9bea2

Signed-off-by: marquesja1 <[email protected]>

Apply reviewer's comments

f533df2

Signed-off-by: marquesja1 <[email protected]>

Apply reviewer's comments

60f0e77

Signed-off-by: marquesja1 <[email protected]>

rcourtier approved these changes Oct 30, 2024

View reviewed changes

Merge branch 'main' into network_modification_replace_threeWindingsTr…

a526995

…ansformers_by_3_twoWindingsTransformers

olperr1 added the Breaking Change API is broken label Nov 14, 2024

olperr1 requested changes Nov 15, 2024

View reviewed changes

marqueslanauja and others added 9 commits November 19, 2024 10:25

Update iidm/iidm-modification/src/main/java/com/powsybl/iidm/modifica…

9e204a3

…tion/Replace3TwoWindingsTransformersByThreeWindingsTransformers.java Co-authored-by: Olivier Perrin <[email protected]> Signed-off-by: marqueslanauja <[email protected]>

Update iidm/iidm-modification/src/main/java/com/powsybl/iidm/modifica…

80f2918

…tion/Replace3TwoWindingsTransformersByThreeWindingsTransformers.java Co-authored-by: Olivier Perrin <[email protected]> Signed-off-by: marqueslanauja <[email protected]>

Update iidm/iidm-modification/src/main/java/com/powsybl/iidm/modifica…

d857607

…tion/Replace3TwoWindingsTransformersByThreeWindingsTransformers.java Co-authored-by: Olivier Perrin <[email protected]> Signed-off-by: marqueslanauja <[email protected]>

Update iidm/iidm-modification/src/main/java/com/powsybl/iidm/modifica…

6c1f5ec

…tion/ReplaceThreeWindingsTransformersBy3TwoWindingsTransformers.java Co-authored-by: Olivier Perrin <[email protected]> Signed-off-by: marqueslanauja <[email protected]>

Update iidm/iidm-modification/src/main/java/com/powsybl/iidm/modifica…

933eac7

…tion/ReplaceThreeWindingsTransformersBy3TwoWindingsTransformers.java Co-authored-by: Olivier Perrin <[email protected]> Signed-off-by: marqueslanauja <[email protected]>

Update iidm/iidm-modification/src/main/java/com/powsybl/iidm/modifica…

d8587b2

…tion/ReplaceThreeWindingsTransformersBy3TwoWindingsTransformers.java Co-authored-by: Olivier Perrin <[email protected]> Signed-off-by: marqueslanauja <[email protected]>

Update iidm/iidm-modification/src/main/java/com/powsybl/iidm/modifica…

8e957f6

…tion/ReplaceThreeWindingsTransformersBy3TwoWindingsTransformers.java Co-authored-by: Olivier Perrin <[email protected]> Signed-off-by: marqueslanauja <[email protected]>

Update iidm/iidm-modification/src/main/java/com/powsybl/iidm/modifica…

7f26d9a

…tion/ReplaceThreeWindingsTransformersBy3TwoWindingsTransformers.java Co-authored-by: Olivier Perrin <[email protected]> Signed-off-by: marqueslanauja <[email protected]>

Implement some of the reviewers' comments

b09b498

Signed-off-by: marquesja1 <[email protected]>

olperr1 requested changes Nov 20, 2024

View reviewed changes

...om/powsybl/iidm/modification/Replace3TwoWindingsTransformersByThreeWindingsTransformers.java Outdated Show resolved Hide resolved

...om/powsybl/iidm/modification/ReplaceThreeWindingsTransformersBy3TwoWindingsTransformers.java Outdated Show resolved Hide resolved

marqueslanauja added 4 commits November 20, 2024 13:47

Apply reviewer's comments

ff66db4

Signed-off-by: marquesja1 <[email protected]>

Minor changes

ba85837

Signed-off-by: marquesja1 <[email protected]>

Fix the copy of operationalLimitsSet properties

325d742

Signed-off-by: marquesja1 <[email protected]>

Apply reviewer's comments

de78db8

Signed-off-by: marquesja1 <[email protected]>

olperr1 requested changes Nov 22, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Network modification. Replace threeWindingsTransformers by 3 twoWindingsTransformers and vice versa #3167

Network modification. Replace threeWindingsTransformers by 3 twoWindingsTransformers and vice versa #3167

marqueslanauja commented Oct 2, 2024 •

edited by olperr1

Loading

olperr1 Nov 15, 2024

marqueslanauja Nov 20, 2024

olperr1 Nov 22, 2024

sonarcloud bot commented Nov 22, 2024

olperr1 Nov 22, 2024

olperr1 Nov 22, 2024

olperr1 Nov 22, 2024

olperr1 Nov 22, 2024

olperr1 Nov 22, 2024

olperr1 Nov 22, 2024

		ThreeWindingsTransformerAdder t3wAdder = substation.newThreeWindingsTransformer()
		.setId(getId(twoR))

		.newTwoWindingsTransformer()
		.setId(t3w.getId() + "-Leg" + leg.getSide().getNum())

Network modification. Replace threeWindingsTransformers by 3 twoWindingsTransformers and vice versa #3167

Are you sure you want to change the base?

Network modification. Replace threeWindingsTransformers by 3 twoWindingsTransformers and vice versa #3167

Conversation

marqueslanauja commented Oct 2, 2024 • edited by olperr1 Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarcloud bot commented Nov 22, 2024

Quality Gate passed

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marqueslanauja commented Oct 2, 2024 •

edited by olperr1

Loading