Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: dealing with err.name on Node v8 #25

Merged
merged 5 commits into from
Jun 3, 2017
Merged

Fix: dealing with err.name on Node v8 #25

merged 5 commits into from
Jun 3, 2017

Conversation

twada
Copy link
Member

@twada twada commented Jun 3, 2017 •
edited
Loading

v8's e.name contains error code like AssertionError [ERR_ASSERTION]

@coveralls
Copy link

coveralls commented Jun 3, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 98.413% when pulling 85d4841 on node-v8 into a473664 on master.

@twada
Copy link
Member Author

twada commented Jun 3, 2017 •
edited
Loading

Realized that this PR should be separated in two parts. AssertionError detection using Regexp should be released ASAP.
In contrast, recreating AssertionError instance, I must think more carefully.

So I'm breaking this PR in two. Going to land the first part.

@coveralls
Copy link

coveralls commented Jun 3, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 98.333% when pulling b4c1ce7 on node-v8 into a473664 on master.

@twada twada changed the title Recreate AssertionError if message is modified and running under Node v8 Fix: dealing with err.name on Node v8 Jun 3, 2017
@twada twada merged commit 793f8c5 into master Jun 3, 2017
@twada twada deleted the node-v8 branch June 3, 2017 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@twada @coveralls