PHP 8.1 support (#134)

* PHP 8.1 support

Still a WIP until closer to the release date

* Minor fixes

* Fix typo

* More updates

* Use a test which works in both old and new phpunit versions without
warning

src/Command/RunCommand.php

@@ -235,6 +235,11 @@ private function createOption(InputInterface $input): Option
     private function getCSVOption(InputInterface $input, string $option): array
     {
         $result = $input->getOption($option);
+
+        if (null === $result) {
+            return [];
+        }
+
         if (false === is_array($result)) {
             return array_filter(
                 explode(',', (string) $result),
@@ -244,9 +249,6 @@ static function ($value) {
             );
         }
 
-        if (null === $result) {
-            return [];
-        }
 
         return $result;
     }

tests/Command/RunCommandTest.php

@@ -67,6 +67,14 @@ public function testItDoesNotFailCommandWhenFileOnPathDoesNotExist(): void
         ]);
 
         $this->assertSame(RunCommand::SUCCESS, $this->commandTester->getStatusCode());
-        $this->assertRegExp('/No files found to scan/i', $this->commandTester->getDisplay());
+        $output = $this->commandTester->getDisplay();
+
+        /* This should use assertStringContainsString but the lowest phpunit supported does not allow that */
+        $found = false;
+        if (strpos($output, 'No files found to scan') !== false) {
+            $found = true;
+        }
+
+        $this->assertTrue($found);
     }
 }

tests/Printer/XmlTest.php

@@ -17,7 +17,6 @@ class XmlTest extends TestCase
     public function testEmpty() : void
     {
         $outputPath = tempnam(sys_get_temp_dir(), 'phpmnd_');
-
         $xmlPrinter = new Xml($outputPath);
         $xmlPrinter->printData(new NullOutput(), new HintList(), []);