Review 5186 - #20
Merged
Merged
Conversation
Author
|
cc @potuz |
potuz
reviewed
May 12, 2026
| assert head.payload_status != PAYLOAD_STATUS_PENDING | ||
| if head.payload_status == PAYLOAD_STATUS_EMPTY: | ||
| def should_build_on_full(store: Store, root: Root) -> bool: | ||
| if not should_extend_payload(store, root): |
Owner
There was a problem hiding this comment.
This feels weird to call all this function when it's just equivalent to is_payload_verified for the proposer. OTOH, the payload could be verified but the head still be empty, this is the reason I decided to go with head in my PR instead of just root.
Author
There was a problem hiding this comment.
yes, this is indeed a bug in my refactor, addressed this in 795050c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.