Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use wider range for ember-cli-babel #234

Merged
merged 1 commit into from
Apr 24, 2020

Conversation

alexlafroscia
Copy link
Contributor

Changes proposed in this pull request

After installing the latest version of this package, I noticed [email protected] added to my lockfile. That seemed odd, and I traced it back to this package only allowing that specific version to be used.

I don't believe there's any reason that a newer version shouldn't be allowed for compiling the files from this add-on, and we can reduce the number of dependencies users of this package need to install if they can resolve the version needed here to a more modern one that they may already be using.

@snewcomer snewcomer merged commit dd7894a into poteto:master Apr 24, 2020
@snewcomer
Copy link
Collaborator

emberjs/ember.js#18827

FYI this was the issue why we had to pin babel...

Thanks for the PR!

@alexlafroscia
Copy link
Contributor Author

Huh, interesting! I’ve run into that myself, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants