fixes incorrect usage of $GOBIN #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like Travis fails because it expects the ':' as part of the path (erroneously). Should I fix up the test? I see the last commit was "test is deprecated". Not sure. As usual, thanks for your work on these tools, pote! |
|
Hum, good call, for all my work in gpm I've been neglecting gvp a lot though, thanks for spotting this! Yeah, let's adapt the test to the correct behaviour for GOBIN then I'll merge and make a new release for homebrew. :) Thanks for all your help! <3 |
gobin in this case should *only* point to the .godeps/bin directory, otherwise you end up with .godeps / bin / bin: / <-- where binaries are actually placed by go get when it should obviously only be in .godeps/bin also fixed test
|
Cool. Removed the ORIGINAL_GOBIN from the test too, now passes on TravisCI again 👍 |
|
<3! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gobin in this case should only point
to the .godeps/bin directory, otherwise you end up with
when it should obviously only be in
.godeps/bin.I also fixed some oddities regarding setting things to be exported.