Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes URL in wptest-cli-install.sh #32

Merged
merged 1 commit into from
Jun 13, 2014

Conversation

franz-josef-kaiser
Copy link
Contributor

Fixed the URL for the bash/shell to pull the right file contents. Fixes "not a valid WXR file" error when trying to run the script. Fixes #31

@manovotny
Copy link
Contributor

So this alters what @GaryJones did just a week ago in #30.

I don't use the WordPress CLI, so I have no idea what is going on here and I don't want to keep blindly accepting pull requests flopping back and forth.

Can someone kindly explain to me what the difference is between all these URLs and how it's helps / hurts the WordPress CLI?

@GaryJones
Copy link
Contributor

My URL forwards on to the one @franz-josef-kaiser gave (try https://github.com/manovotny/wptest/raw/master/wptest.xml and see where you end up), and it worked for me. I purposely avoided using the resulting URL, in case GH kept the long-standing raw (my) URL, and later changed it to something else.

If it's causing an error for someone else though, of course, go ahead and accept it.

@franz-josef-kaiser
Copy link
Contributor Author

@GaryJones yes, it seemed to not redirect for me on Ubuntu 12.04 LTS. At least targetting the file directly helped.

@manovotny That one doesn't alter what WP-CLI does, but only changes the curl target. You can try the result from your local shell. If you don't have curl, maybe it can be replicated using wget.

manovotny added a commit that referenced this pull request Jun 13, 2014
Fixes URL in wptest-cli-install.sh
@manovotny manovotny merged commit e655830 into poststatus:master Jun 13, 2014
@manovotny
Copy link
Contributor

Ok, we'll roll with this pull request as it takes you directly to the resolved URL.

Please let me know if you experience any issues after doing so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bash/Shell scripts fails
3 participants