-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional HTTP authorization types #2
base: main
Are you sure you want to change the base?
Conversation
// An application-specific authorization header, such as | ||
// Github webhook's X-Hub-Signature-256 or X-Hub-Signature, | ||
// *not* carried in "Authorization". | ||
PROPRIETARY_HEADER = 11; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think consumers of the IR currently assume that these authorization types are associated with the Authorization
header. We'll need to weed out all the places that make this assumption.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The conversion to/from OpenAPI2/3 will need to be updated, as well as the translation of the IR -> frontend data structures. Maybe the visitors as well, @liujed? Seems doable though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I recall, parts of the GitHub comment generator will need to be updated too. Certainly doable; just need to be careful to examine all the places where we look at these values.
// An application-specific authorization header, such as | ||
// Github webhook's X-Hub-Signature-256 or X-Hub-Signature, | ||
// *not* carried in "Authorization". | ||
PROPRIETARY_HEADER = 11; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The conversion to/from OpenAPI2/3 will need to be updated, as well as the translation of the IR -> frontend data structures. Maybe the visitors as well, @liujed? Seems doable though.
This includes: