fix: OpenAPI spec invalid #710
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jspdown
force-pushed
the
fix/oas-spec
branch
from
25ecaf1
to
4e1348c
Compare
|
Are all those "required" additions really "required"? Note that I've only quickly squinted at this MR through the prism of the "diff" so I am missing some context. The nb: You might want to move this PR over to https://github.com/psf/httpbin |
|
@exhuma Thanks for your feedback. The Parameter object defined in the OAS v2 specification has a special requirement when the type of a parameter is
About psf/httpbin, I wasn't aware of this fork. I will make sure to submit the PR there as well. |
|
Checking the PRs there, could you please send it to the fork, too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the generated OpenAPI spec document to be v2.0 compliant.
The most important changes are the removal of the deprecated/non-standard SmartAPI fields
responsibleOrganizationandresponsibleDeveloper. And the removal of the non-standardprotocolfield at the top level.These fields alone prevented the use of HTTPBin spec on most OAS compliant tooling.