Skip to content

Docs contributors #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jan 30, 2019
Merged

Docs contributors #227

merged 15 commits into from
Jan 30, 2019

Conversation

RalphJbeily
Copy link
Contributor

This PR is to add the contributors to this project

@RalphJbeily RalphJbeily self-assigned this Jan 28, 2019
Copy link
Contributor

@adampash adampash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change it so it’s the small version of the contributor list. Like small avatars, not the big table that’s there now? Is that possible with this tool?

This could presumably grow rather large, so we should prepare for that.

@RalphJbeily
Copy link
Contributor Author

@adampash Yes it is possible to modify the table, I updated the .all-contributorsrc file, resized the images to 50px and defined the contributors per line to be 6 which I think it can be changed to 8 and fill the remaining empty area and @george-haddad what do you guys think ?

@george-haddad
Copy link
Contributor

@adampash Yes it is possible to modify the table, I updated the .all-contributorsrc file, resized the images to 50px and defined the contributors per line to be 6 which I think it can be changed to 8 and fill the remaining empty area and @george-haddad what do you guys think ?

I think you are going in the right direction, though the 50px seemed like a good idea at first but when I looked at the file it seemed too small. Maybe a size like 80px might be better suited and increasing the number of contributors per line to 7 or 8, depending on how to looks.

@RalphJbeily
Copy link
Contributor Author

@adampash Yes it is possible to modify the table, I updated the .all-contributorsrc file, resized the images to 50px and defined the contributors per line to be 6 which I think it can be changed to 8 and fill the remaining empty area and @george-haddad what do you guys think ?

I think you are going in the right direction, though the 50px seemed like a good idea at first but when I looked at the file it seemed too small. Maybe a size like 80px might be better suited and increasing the number of contributors per line to 7 or 8, depending on how to looks.

Yes I modified the table to support 8 contributors per line and it looks good so far with the increased images size, let me know what do you think

Copy link
Contributor

@george-haddad george-haddad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine to me

@george-haddad george-haddad merged commit 199fe70 into master Jan 30, 2019
@george-haddad george-haddad deleted the docs-contributors branch January 30, 2019 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants