-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: hook up ci to publish to npm #226
Conversation
What's bugging me about this test is that it should be doing everything at UTC timezone offset. Which for this date would be But if I preserve the timezone offset as an ISO string it will include I think we should create a task to re-code all the |
@george-haddad I think that's completely sensible. Do you want to make an issue out of it? |
"bundleDependencies": [ | ||
"jquery", | ||
"moment-timezone" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've not done this before, but wouldn't bundleDependencies
include all of the browser dependencies below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the node_modules
directory of the package and it only included those 2 single packages. The test create-react-app
won't start without them and this was the only way to get them bundled in the npm package.
It doesn't seem to impact the build, but technically it should be there so for good measure, why not...
This pull request will set up mercury for publishing to
npm
Publishing manually
npm login
npm publish
to publish package privatelynpm publish --access public
to publish the package publiclyThe way it is setup is that Circle CI will listen for a git tag event that follows the naming convention of
v0.0.0
and that will trigger an npm publish.The current config is set to publish the package publicly, so merging the PR should be fine and not trigger a publish until a git tag is created.