Fix diff in the test moc100 on PG16 #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I confused as to why this change is working on PG 10-15. I thought only the PG16 build broke and the test output was unaltered on PG 10-15. |
Contributor
Author
|
@esabol expected/moc100_4.out is applied only in case of PG16: https://www.postgresql.org/docs/current/regress-variant.html Other "golden" files expected/moc100_*.out are applied for other versions of postgres. You can see that the beginning of each file contains some output that is specific for each version. It plays the role of a filter. For unsuitable versions, it will produce differences and the golden file will be skipped. |
Contributor
|
Oh, interesting! |
esabol
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.