Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Helm release action that works with tags #3

Merged
merged 2 commits into from
Dec 1, 2021

Conversation

treydock
Copy link
Contributor

@treydock treydock commented Dec 1, 2021

This is message from Github Action using official Helm chart:

Discovering changed charts since 'v0.1.1'...
Nothing to do. No chart changes detected.

This is long standing and very annoying issue with Helm's official chart where it doesn't want to do releases on tags. The only place I have been able to use the Helm official action is repos not using tags to handle releasing a chart. On several projects I contribute to and many I manage, I've had to use third party actions to handle releases to gh-pages for Helm charts.

@treydock
Copy link
Contributor Author

treydock commented Dec 1, 2021

Upstream PR that might fix this but currently not merged: helm/chart-releaser-action#96. There are several issues on that repo about not being able to publish with tags.

@clementnuss
Copy link
Contributor

you're right, I tried to understand what the official releaser does but it indeed messes with tags.
even tried committing without a tag but without success.
Merging again your third-party solution, could you just please specify a specific version of the third-party gh-action instead of latest please?

I've subscribed to the official gh-pages helm releaser PR for tags, will check it once they merge it

@clementnuss clementnuss merged commit 9de5815 into postfinance:main Dec 1, 2021
@coveralls
Copy link

coveralls commented Dec 1, 2021

Pull Request Test Coverage Report for Build 1526236249

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.988%

Totals Coverage Status
Change from base Build 1525325814: 0.0%
Covered Lines: 128
Relevant Lines: 173

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants