Fixed a bug that could cause regexp to issue an error #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // `a { /*i*/ } /*i2*/ a b {} /*i3*/ a s {}` | ||
| // ) | ||
| // }) | ||
|
|
There was a problem hiding this comment.
I added this test to see what happens if there are several rules with comments in the description.
The test does not work - it does not connect selectors for the second nested one.
I tried to fix it, but in your code, the devil will break my leg.
Does it make sense to fix it?
|
I will release it a few hours later |
|
Thanks! |
|
Oh, but I just fixed the error mentioned above with new commits. You noticed her, didn't you? The error was that the rules with several nested rules to which comments were attached were incorrectly processed. |
|
The fix was released in 7.0.1. Thanks to @Ulyanov-programmer |
This was referenced Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the regular expression so that it ignores those places where there are inconvenient characters.