perf!: make yaml dependency optional#261
Merged
ai merged 1 commit intopostcss:mainfrom Jun 1, 2024
ArnaudBarre:optionnal-yaml
Merged
perf!: make yaml dependency optional#261ai merged 1 commit intopostcss:mainfrom ArnaudBarre:optionnal-yaml
ai merged 1 commit intopostcss:mainfrom
ArnaudBarre:optionnal-yaml
Conversation
9 tasks
Member
|
Yes, I like the idea of reducing But since it is breaking change, I need to think a little. |
Contributor
Author
|
Thanks for considering it! There is also a slight runtime perf benefit because node doesn't need to process the full |
Member
|
Seems like there is only ≈100 Not really popular config. |
Member
|
Released in 6.0. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notable ChangesThe direct
yamldependency is currently adding ~250kb to Vite bundle size for something that seems to be a very small usecase. I think it's better to make it a peer dependency and release a majorCommit Message Summary (CHANGELOG)TypeSemVerChecklist