-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suport for alternative PostCSS syntaxes #79
Conversation
I don't understand what this is about. Care to add a test? |
Added: support for alternative PostCSS syntaxes
PostCSS 6.0 has custom parsers. So user can work not only with CSS sources, but also with SCSS (for eample, for inline comment). So if it import some file, we need to use parent processor parser. |
I see you added postcss-scss as a dev dep but I don't see any tests, did you forget to add them ? |
👍 what is the status of this feature? I preffer use postcss-import over to postcss-partial-import but for now i don't have alternative if i'm using SCSS |
I am just waiting for a minimal automated test to be able to merge. |
ahh ok! one more thing. @jonathantneal I think that you need to do some change with the line 367 because for example for inline comments in SCSS is necessary use postcss-scss as the parser. maybe something like this, what do you think? var parseFunc = (result.opts && result.opts.parser)
? result.opts.parser.parse
: postcss.parse
var newStyles = parseFunc(fileContent, options) |
Maybe it would be easier if we just merge the two projects, and keep the import functionality like it is in PostCSS import and make the include functionality like it is in PostCSS partial import? |
The idea of your plugin is just to add a prefix before the last part of the name of the file right? I don't see how you created another plugin for that and not just did a PR in the first place. This has already been discussed here #39 and the issue is still open (so PR are welcome, has always). |
+1 on this, any chance of getting this trough ? :) (helps with a lot of projects being sass based) |
@CoolGoose If I am correct, I think @TrySound will handle that very soon. |
Closed by 9c168b9, will land in master soon. |
Added: support for alternative PostCSS syntaxes