Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resolve tests #153

Merged
merged 4 commits into from
Jan 19, 2016
Merged

Add resolve tests #153

merged 4 commits into from
Jan 19, 2016

Conversation

TrySound
Copy link
Member

fix #101

@TrySound
Copy link
Member Author

There is a problem in resolve I think. On my windows machine everything is okay.

@TrySound
Copy link
Member Author

Done. Sorry for noise. Reverted issue with resolve. Will try to break again in the next time.

@MoOx
Copy link
Contributor

MoOx commented Jan 17, 2016

Any idea why appveryor is broken?

@TrySound
Copy link
Member Author

@MoOx Something wrong with npm. I don't think it make sense. branch build was successed.
P.S. Welcome back :)

@MoOx
Copy link
Contributor

MoOx commented Jan 17, 2016

So from what I understand, no breaking changes in this PR?

@TrySound
Copy link
Member Author

I added main field detect, made more detailed tests and fixed options.root using.

@MoOx
Copy link
Contributor

MoOx commented Jan 17, 2016

Can you add the added stuff in the CHANGELOG please?

@TrySound
Copy link
Member Author

/cc @MoOx

MoOx added a commit that referenced this pull request Jan 19, 2016
@MoOx MoOx merged commit 12efd77 into dev Jan 19, 2016
@MoOx MoOx deleted the resolve-test branch January 19, 2016 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants