-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom load support #144
Conversation
@MoOx Maybe we should in the same way remove glob support? I created api which let in fast way add this feature. postcssImport({
resolve: function (id, base, opts) {
return glob.sync(path.join(base, id));
}
}) |
I am sure a lot of people use glob and don't want to type this function. Let's keep it in the core. |
@MoOx Cause I replaced it with custom load. I think it more consistent way. |
So please can you add in the CHANGELOG a way to migrate? Thanks :) |
Like this? |
I just would like to keep core as small as it possible. And glob support is weird in browser way. We made good and simple api for that. glob can be realized in the same way as encoding support. Also globs can be realized in different ways. What we did can be not what users expect. |
So if we remove things like that, I really think we should provide snippets "ready to use" to provide an easy upgrade. |
@MoOx The same like encoding example? |
Yeah that's cool. (btw, why did you used fs sync in it?) |
@MoOx It's simpler than wrapping async in promise :) |
No description provided.