Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post message to parent when ready #166

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Post message to parent when ready #166

merged 2 commits into from
Jul 30, 2024

Conversation

wch
Copy link
Collaborator

@wch wch commented Jul 30, 2024

If there is a parent window, the App will now post a message to the parent when it is ready.

Notes:

  • Currently, "ready" means that it is ready to receive setFiles messages posted to the this window, but conceivably one might want to have signals of other events (like when the app actually starts running), so it might make sense to have a message type that can represent multiple types of events.

@wch wch requested a review from jcheng5 July 30, 2024 15:27
src/Components/App.tsx Outdated Show resolved Hide resolved
@jcheng5 jcheng5 marked this pull request as ready for review July 30, 2024 17:07
@jcheng5 jcheng5 merged commit bcb472b into main Jul 30, 2024
2 checks passed
@jcheng5 jcheng5 deleted the message-on-ready branch July 30, 2024 17:16
@jcheng5 jcheng5 restored the message-on-ready branch July 30, 2024 17:16
@wch wch deleted the message-on-ready branch July 31, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants