Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shinyswatch to v0.7.0 #157

Merged
merged 3 commits into from
Jul 19, 2024
Merged

Update shinyswatch to v0.7.0 #157

merged 3 commits into from
Jul 19, 2024

Conversation

gadenbuie
Copy link
Contributor

Fixes #156

Makes shinyswatch a submodule so that we can explicitly update the bundled version of shinyswatch.

@gadenbuie gadenbuie requested review from schloerke and wch July 19, 2024 16:00
@wch
Copy link
Collaborator

wch commented Jul 19, 2024

One of the make targets will update the shinylive_lock.json file, so it’s not necessary to use a submodule here.

@wch
Copy link
Collaborator

wch commented Jul 19, 2024

The make target is update_packages_lock. The reason it doesn’t automatically run with make all is so that the locked packages aren’t accidentally updated - I believe that updating some of them right now will cause shinylive to break. You can run that make target and then only keep the changes to the shinyswatch entry in the lock file.

@gadenbuie gadenbuie changed the title chore: make shinyswatch a submodule Update shinyswatch to v0.7.0 Jul 19, 2024
@gadenbuie gadenbuie requested review from wch and removed request for wch July 19, 2024 19:58
@wch wch merged commit cd96b8b into main Jul 19, 2024
2 checks passed
@wch wch deleted the update/shinyswatch branch July 19, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update py-shinyswatch to v0.7.0
3 participants