fix(markdown-stream): Scroll to bottom when tool request/results finish rendering #157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scrolling to the bottom of the chat stream can be broken (or just generally wonky) when there are many tool requests/results in a message.
This happens generally because the scroll-to-bottom logic runs just after rendering the message content, at which point the tool request/results are still empty containers and haven't yet been rendered by lit, so the scrolling isn't quite in line with the bottom of the container, or can drift.
The fix in this PR is to emit a
shiny-chat-maybe-scroll-to-bottomevent when the request/result isfirstUpdated(), i.e. when it is rendered in the DOM, which then calls into the same scroll to bottom logic that is used when the chat message is updated.Example
Here's a small example app I've been using (the weather tool). Make the window height small and ask a question that leads to checking the weather in a few cities at once.
Example app