Skip to content

fix: include_css and include_js can't use files from same dir - #2069

Merged
cpsievert merged 17 commits into
mainfrom
fix/js_css_inclusion
Sep 2, 2025
Merged

fix: include_css and include_js can't use files from same dir#2069
cpsievert merged 17 commits into
mainfrom
fix/js_css_inclusion

Conversation

@elnelson575

@elnelson575 elnelson575 commented Aug 25, 2025

Copy link
Copy Markdown
Contributor

Closes #729

@elnelson575 elnelson575 linked an issue Aug 25, 2025 that may be closed by this pull request
@elnelson575 elnelson575 self-assigned this Aug 25, 2025
@elnelson575
elnelson575 requested a review from cpsievert August 25, 2025 16:30
@elnelson575
elnelson575 marked this pull request as ready for review August 26, 2025 18:37
Comment thread tests/playwright/shiny/bugs/2061-css-js-inclusion/www/customjs.js Outdated
Comment thread tests/playwright/shiny/bugs/2061-css-js-inclusion/app.py
Comment thread tests/playwright/shiny/bugs/2061-css-js-inclusion/js/customjs.js Outdated
Comment thread tests/playwright/shiny/bugs/2061-css-js-inclusion/css/style.css Outdated
Comment thread tests/playwright/shiny/bugs/2061-css-js-inclusion/app.py Outdated
Comment thread shiny/ui/_include_helpers.py Outdated
Comment thread shiny/ui/_include_helpers.py Outdated
Comment thread shiny/ui/_include_helpers.py Outdated
Comment thread shiny/ui/_include_helpers.py Outdated
elnelson575 and others added 3 commits September 2, 2025 16:31
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
@cpsievert
cpsievert merged commit 32eb05d into main Sep 2, 2025
125 of 128 checks passed
@cpsievert
cpsievert deleted the fix/js_css_inclusion branch September 2, 2025 22:28
@cpsievert

Copy link
Copy Markdown
Collaborator

@elnelson575 for future reference, it would be great if all PRs include a Closes #n as well as an update to the CHANGELOG.md

@cpsievert cpsievert changed the title fix: include_css and include_js can use files in same dir fix: include_css and include_js can't use files from same dir Sep 2, 2025
@elnelson575 elnelson575 linked an issue Sep 5, 2025 that may be closed by this pull request
schloerke added a commit that referenced this pull request Sep 5, 2025
* main:
  fix: Make outside users able to read tmp files (#2070)
  docs: update module server and ui to incorporate #705 (#2044)
  fix: errors on bookmark are now surfaced in the Python console (#2076)
  Add Connect Cloud as a hosting option in README (#2074)
  Update changelog
  Update changelog
  fix: include_css and include_js can use files in same dir (#2069)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not possible to include CSS & Javascript include helpers don't work when used twice in the same dir

2 participants