Skip to content

docs: docstring for core shiny.modules.ui and shiny.module.server - #1974

Merged
cpsievert merged 22 commits into
posit-dev:mainfrom
chendaniely:api-docs-module-ui-server
Apr 29, 2025
Merged

docs: docstring for core shiny.modules.ui and shiny.module.server#1974
cpsievert merged 22 commits into
posit-dev:mainfrom
chendaniely:api-docs-module-ui-server

Conversation

@chendaniely

Copy link
Copy Markdown
Contributor

Adding missing docstrings for shiny.module

Comment thread shiny/module.py Outdated
Comment thread shiny/module.py
Comment thread shiny/module.py Outdated
@chendaniely
chendaniely force-pushed the api-docs-module-ui-server branch from d8a9b94 to 328de17 Compare April 18, 2025 18:27
@chendaniely

This comment was marked as outdated.

Comment thread shiny/module.py Outdated
Comment thread shiny/module.py Outdated
Comment thread shiny/module.py Outdated
@chendaniely
chendaniely force-pushed the api-docs-module-ui-server branch from a861b72 to c86a827 Compare April 25, 2025 02:04
@chendaniely

Copy link
Copy Markdown
Contributor Author

things should be fixed now. Part of the issue was using the variable: return type notation when type hints were already defined for the function. I think that was the cause of the rendering issue

image

Comment thread shiny/api-examples/Module/app-express.py Outdated
Comment thread shiny/module.py Outdated
Comment thread shiny/module.py Outdated
chendaniely and others added 4 commits April 28, 2025 16:33
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
@chendaniely

chendaniely commented Apr 29, 2025

Copy link
Copy Markdown
Contributor Author

Needed the changes from 94a9024 to get the links to show correctly

image

@cpsievert cpsievert left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants