Skip to content

chore(lint): Set pyright version to 1.1.365 to avoid error in 3.12 checks #1459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schloerke merged 1 commit into from
Jun 10, 2024
Merged

chore(lint): Set pyright version to 1.1.365 to avoid error in 3.12 checks #1459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ dev =
flake8>=6.0.0
flake8-bugbear>=23.2.13
isort>=5.10.1
pyright>=1.1.348
pyright==1.1.365 # must be larger than 1.1.366; https://github.com/microsoft/pyright/issues/8087

@cpsievert cpsievert Jun 10, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schloerke should the comment say "must not be"?

@schloerke schloerke Jun 10, 2024

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Suggested change
pyright==1.1.365 # must be larger than 1.1.366; https://github.com/microsoft/pyright/issues/8087
pyright==1.1.365 # In the future... the version must be larger than 1.1.366; https://github.com/microsoft/pyright/issues/8087

@schloerke schloerke Jun 10, 2024

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea... either one works!

pre-commit>=2.15.0
wheel
matplotlib
Expand Down