Workaround for pygls performance issue #6219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 |
austin3dickey
approved these changes
Feb 5, 2025
| # Call `_data_received` instead of `data_received` so that errors are raised. | ||
| protocol._data_received(data) # noqa: SLF001 | ||
|
|
||
| assert not did_hover_executed |
There was a problem hiding this comment.
Like you said, not sure how to test this by hovering locally, but this unit test looks good!
isabelizimm
approved these changes
Feb 5, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for openlawlibrary/pygls#517 until it's fixed upstream.
Release Notes
New Features
Bug Fixes
QA Notes
I'm not sure how to reproduce this, but nothing should break.