Update render on demand API calls

[nealrichardson]

I chatted with @aronatkins and read through the source. To render, we don't need query params or body in the POST; params were removed in 2021. To send email, only query params are checked. So I simplified the recipe here.

@kmasiello I did not test that this code works--can you confirm using whatever example you were developing this with?

I'll separately update what connectapi does (which I think is where the confusion came from).

[kmasiello]

The python code works fine.

The R code does not.

If you want to test:

• Environment: Colorado
• content_guid: cdadc17a-418a-42d5-8212-cef7d639ee58
• some valid variant keys: aCfL13z8, lsa46Ax3 (default)

[nealrichardson]

For R, it looks like you dropped query and kept body. It should be the other way around.

[kmasiello]

No dice. It requires body

  client$POST(post_url, 
              query = list(email = recipients, rendering_id = rendering_id), 
              # body = list(email = recipients, rendering_id = rendering_id)
              )
}
Error:
! argument "body" is missing, with no default
Hide Traceback
    ▆
 1. └─client$POST(...)

[nealrichardson]

Thanks. I'll poke at it some more.

[nealrichardson]

I fixed the POST error in rstudio/connectapi#274. I've done some further simplification, depending on connectapi changes in rstudio/connectapi#277. There's more to pull on, but I don't have time right now. I will try to confirm the changes on Colorado.

[nealrichardson]

TODO: connectapi::get_variant() should cleanly handle the case where a variant key isn't found.

[kmasiello]

It's amazing! Installed connectapi from the dev branch and send_email works! 🎉

[toph-allen]

Code from this PR were incorporated into #125.